Compatibility with prompt_toolkit 2.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
prompt_toolkit-2.0
branch
from
950abc1
to
de0763d
Compare
jonathanslenders
changed the title
|
Picking up this project again. Lots of refactoring, including refactoring of my use of prompt_toolkit will be done. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should do the most important changes for compatibility with prompt_toolkit 2.0, when this is released.
This will also require ptpython 2.0 and pyvim 2.0 (both are also not yet released, but will be released together with prompt_toolkit 2.0).
In the meantime, it could be good to pin the version of both these dependencies on the 1.0 version, so that when prompt_toolkit 2.0 is released, we're not going to break stuff right away.