Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: copy wallet mnemonic #56

Closed
jayruffing opened this issue Nov 20, 2021 · 5 comments · Fixed by #88
Closed

feature request: copy wallet mnemonic #56

jayruffing opened this issue Nov 20, 2021 · 5 comments · Fixed by #88
Labels
enhancement New feature or request

Comments

@jayruffing
Copy link

as a user who creates a new wallet in the mobile app
I want to be able to easily backup my 15-word mnemonic
so that I can recover my wallet at a later date and not lose all my assets (after I damaged/lost my phone)

the wallet setup screen does require specific words from the mnemonic to be entered that should make the user backup/write down the mnemonic but often the mobile user will take a screenshot to do this b/c it's easiest but that's very bad. enabling copy of the mnemonic to the clipboard would help some users put this in a safe(r) place like a password manager which is also not-the-best-practice but it's sufficient for some and better than a screenshot. I know iOS put some privacy constraints recently on clipboard access - not sure if that adds complexity here or not. mnemonic phrase copy to the clipboard to me is very nice-to-have as I use a password manager for some light wallets for convenience outside my ledger/steel seed phrase). Anyways, many wallets out there enable this feature and many don't. if you don't like it / want to implement it I think that's just fine.

That said, I think that at a minimum, there should be a way for the user to back up the mnemonic post-wallet creation should the original mnemonic backup be lost. see Trust Wallet's implementation for a decent example of what I have in mind here: https://community.trustwallet.com/t/lost-recovery-phrase-or-private-key/221

@MrStahlfelge
Copy link
Member

There is already a way to redisplay the mnemonic later on the wallet configuration screen. It only shows the mnemonic and can't copy it, that's the same as while creating the wallet.

I can understand the need to copy the mnemonic when you use a password manager to safe it. However, you should be aware that when the mnenomic is in the device's clipboard, every app has access. This could be solved by a warning message.

@aslesarenko what do you think, can we add a copy button which copies the mnemonic after showing a warning message?

@aslesarenko
Copy link
Member

aslesarenko commented Nov 20, 2021

@MrStahlfelge I think yes, we definitely can, but upon tapping on the Copy button the warning message similar to the one you gave above should be shown. It should be short, clear and readable.
The user need to buttons "Cancel" and "Copy and Accept Risks".

@jayruffing
Copy link
Author

ah yes i see that mnemonic backup now....sorry I missed it! I'm used to seeing this functionality in more of the settings context vs clicking on the wallet as a wallet functionality/operation so I didn't expect to see it where it is. If you could add this mnemonic copy functionality I think it would be very useful to many.

@jayruffing jayruffing changed the title feature request: backup wallet mnemonic feature request: copy wallet mnemonic Nov 20, 2021
@MrStahlfelge
Copy link
Member

MrStahlfelge commented Nov 20, 2021

Since you are using the iOS preview I understand the request. When you tap on the wallet on iOS you see the config screen at the moment because the actual details screen (that includes a link to the config) is not done yet. 😉

This is different on Android and will change on iOS, too. Thanks for testing on iOS BTW

@jayruffing
Copy link
Author

thank you very much for your work & contributions @MrStahlfelge & @aslesarenko. I'm just trying to help out too. For context I haven't used the Android app (only Yoroi) and currently my daily driver device is iPhone (12 pro) so this iOS preview is my first exposure to this wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants