Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DB issues explicitly #1120

Closed
kushti opened this issue May 21, 2020 · 2 comments
Closed

Handle DB issues explicitly #1120

kushti opened this issue May 21, 2020 · 2 comments
Assignees
@pragmaxim
Labels
B-500 SigUSD bounty C-feature Category: Feature request or PR help wanted
Milestone
low-priority-tasks

Comments

@kushti
Copy link
Member

kushti commented May 21, 2020

Currently LDBKVStore.update() just prints error messages into the log (since 3.3.0). It is better to not to swallow the DB errors and process them on higher levels.
@kushti kushti added C-feature Category: Feature request or PR help wanted B-150 Erg Bounty: Resolve it and get 150 Erg labels May 21, 2020
@kushti kushti mentioned this issue May 21, 2020
Merged
@kushti kushti added this to the 4.x milestone Jul 8, 2020
@kushti kushti modified the milestones: 4.x, 4.0.9 Feb 12, 2021
@kushti kushti modified the milestones: 4.0.9, 4.0.10 Apr 10, 2021
@kushti kushti added bounty B-500 SigUSD and removed B-150 Erg Bounty: Resolve it and get 150 Erg labels Jun 9, 2021
@pragmaxim pragmaxim self-assigned this Jul 27, 2021
@pragmaxim
Copy link
Collaborator

pragmaxim commented Jul 30, 2021 •
edited

@kushti #1414

I'm also worried about this possible "silent failure"

ergo/src/main/scala/org/ergoplatform/nodeView/state/ErgoStateReader.scala

Line 32 in e6086e2

.flatMap(b => ErgoStateContextSerializer(constants.settings).parseBytesTry(b).toOption)

If the deserialization was failing for some reason, there would be empty state context used everywhere. Impossible to troubleshoot.

Similarly here

ergo/src/main/scala/org/ergoplatform/nodeView/wallet/persistence/WalletRegistry.scala

Line 189 in e68ce61

.flatMap(r => WalletDigestSerializer.parseBytesTry(r).toOption)

@glasgowm148 glasgowm148 modified the milestones: 4.0.10, low-priority-tasks Feb 2, 2022
@pragmaxim
Copy link
Collaborator

Got fixed at #1414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pragmaxim pragmaxim

Labels
B-500 SigUSD bounty C-feature Category: Feature request or PR help wanted
Projects
None yet
Milestone
low-priority-tasks
Development

No branches or pull requests
3 participants
@kushti @pragmaxim @glasgowm148