Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[150 SigmaUSD] Implement MultiplyGroup op for GroupElement. #298

Closed
greenhat opened this issue Jun 8, 2021 · 4 comments
Closed

[150 SigmaUSD] Implement MultiplyGroup op for GroupElement. #298

greenhat opened this issue Jun 8, 2021 · 4 comments
Labels
bounty Bounty for resolving the issue good first issue Good for newcomers

Comments

@greenhat
Copy link
Member

greenhat commented Jun 8, 2021

Create a new struct in a separate module(file) in mir module and add it to Expr enum.
The constructor should check the types of the arguments (see Fold::new, ByIndex::new, etc.).

Serialization

  • Implement SigmaSerializable trait and add node's op code in serialization::expr;
  • Implement Arbitrary trait and add serialization roundtrip PBT test for this node;

Evaluation

  • Implement Evaluable trait in ergotree-interpreter crate;
  • Add evaluation tests;

Check out existing IR node implementation (Fold, ByIndex) for details.
Check out the detailed implementation instructions for Append op in #301

Reference Scala version:
IR node and eval - https://github.com/ScorexFoundation/sigmastate-interpreter/blob/89afefa935d52dd83741f6530f97e4c935992f76/sigmastate/src/main/scala/sigmastate/trees.scala#L1087-L1106

@greenhat greenhat added good first issue Good for newcomers bounty Bounty for resolving the issue labels Jun 8, 2021
@greenhat greenhat changed the title Implement MultiplyGroup op for GroupElement. [150 SigmaUSD] Implement MultiplyGroup op for GroupElement. Jun 8, 2021
@ApexTheory
Copy link
Contributor

I have started on this issue.

@greenhat
Copy link
Member Author

Done in #316.

@greenhat
Copy link
Member Author

Check out your DMs in our discord, please. Your bounty is ready to be sent.

@greenhat
Copy link
Member Author

Thank you! Bounty is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Bounty for resolving the issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants