Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code does not allow you to set activity type and version. #35

Closed
iamnewspecies opened this issue Oct 15, 2015 · 0 comments
Closed

Code does not allow you to set activity type and version. #35

iamnewspecies opened this issue Oct 15, 2015 · 0 comments

Comments

@iamnewspecies
Copy link

The code which lets you set the activity type and version looks more like a hack.
https://github.com/neyric/aws-swf/blob/master/lib/decision-response.js#L169

The code should be like, if sometthing is not there then it should set default value. Else it should take what value is supplied. Currently it sets value only if the first parameter does not contain the key "activity".

if(!swfAttributes) {
if(scheduleAttributes.activity) {
ta.activityType = scheduleAttributes.activity;
}
if (typeof ta.activityType === "string") {
ta.activityType = { name: ta.activityType, version: "1.0" };
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant