Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent method names (camel/snake case) #40

Open
nonplus opened this issue Jan 30, 2016 · 0 comments
Open

Consistent method names (camel/snake case) #40

nonplus opened this issue Jan 30, 2016 · 0 comments

Comments

@nonplus
Copy link

nonplus commented Jan 30, 2016

Most of the APIs in the library consistently follow JavaScript naming conventions and uses camel case (parameter and method names).

However, several of the classes have a mixture of snake-case and camel-case method names. For example, DecisionsResponse has an add_marker() method and an addDecision() method. Similarly, EventList() has a has_timer_event() method and an eventById() method.

It would be nice if the public API of the library consistently used camel case for method names. For backwards compatibility, the existing snake-case function names should be kept as (deprecated) aliases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant