Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass contextual last-flow to float-last() mixin #370

Merged
merged 2 commits into from Sep 24, 2014

Conversation

alertmybanjos
Copy link
Contributor

Fix for issue where the last() mixin always floats in "to" direction regardless of the last-flow setting.

@mirisuzanne
Copy link
Member

Thanks! We should add a test for this. You interested in doing that?

@alertmybanjos
Copy link
Contributor Author

Sure, I'll give it a shot.

@alertmybanjos
Copy link
Contributor Author

Tried compiling the test stylesheets and got this error:
error scss/screen.scss (Line 86 of scss/math/_maps.scss: (hello: ((world: new york, monday: work)), pizza: cheese) isn't a valid CSS value.)

Do I need to lock in particular versions of gems (compass / sass / etc) to work on this?

@mirisuzanne
Copy link
Member

Sorry for the slow response. Yes, you need to be using Sass 3.3+ and Compass 1.0+. There's a gemfile in the test directory, so you can use bundler to manage those versions.

gem install bundler
bundle install
bundle exec compass watch

@alertmybanjos
Copy link
Contributor Author

Thanks for the help. "bundle exec" was what I was missing.

Test added... I think I successfully muddled my way through it.

mirisuzanne added a commit that referenced this pull request Sep 24, 2014
Pass contextual last-flow to float-last() mixin
@mirisuzanne mirisuzanne merged commit 9914263 into oddbird:master Sep 24, 2014
@mirisuzanne
Copy link
Member

Thanks! Sorry it took so long. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants