Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak logging of installation info #10

Merged
merged 1 commit into from Jan 6, 2016
Merged

Tweak logging of installation info #10

merged 1 commit into from Jan 6, 2016

Conversation

insin
Copy link
Collaborator

@insin insin commented Jan 5, 2016

Small things which would drive me to distraction over time 馃槃

Handle singular vs. plural and separate multiple dependencies with a comma
@ericclemmons
Copy link
Member

Haha good point! Just for my own edification, is there a lib you'd recommend to do this?

I was always very deliberate with it:

console.info(
  "Installing missing %s %s...",
  dependencies.length === 1 ? "dependency" : "dependencies",
  dependencies.join(", ")
);

Verbose, but seems like overkill to use a lib :D

Are you partial to one?

@ericclemmons ericclemmons added this to the 1.1.2 milestone Jan 6, 2016
ericclemmons added a commit that referenced this pull request Jan 6, 2016
Tweak logging of installation info
@ericclemmons ericclemmons merged commit 8013589 into webpack-contrib:master Jan 6, 2016
@insin
Copy link
Collaborator Author

insin commented Jan 6, 2016

I can't write a concrete answer to the question because I keep gazing long into into the abyss of YAGNI. I usually write a one-liner pluralisation utility which is capable of doing only what's needed for the current project then quickly close the file at arms' length while turning away with my eyes closed.

@insin insin deleted the pluralisation branch January 6, 2016 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants