-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support .eslintrc
#36
Conversation
Hmmm, maybe not. This looks like it's not easily discernible what all of the dependencies are, because of
|
It may be possible since |
I don't know how I feel about this. It's nice that it's automated, but only know of a handful of examples using @insin @poeticninja @bebraw What do you think? It certainly lowers the barrier for starting a project (e.g. Add |
Examples to support:
|
@ericclemmons It's a niche case for sure. Probably supporting Babel and ESLint for now gets you far. Accept the rest as PRs. 👍 |
Pretty much everyone that is using ESLint (that I have seen) are extending from some other place because there are a lot of rules. Very very few people are actually writing their own rules (I did once and not again). I think supporting extends is important to support ESLint. |
Cool, I think I got this functional. If you guys wanna give it a shot, go for it! |
I just tested it out with |
Here's a good test for ya: This thing has so many peerDependencies and requirements it's absurd. |
@insin What do you think about this feature? Otherwise I'm considering closing it... |
try { | ||
var options = JSON.parse( | ||
fs.readFileSync( | ||
path.join(process.cwd(), ".eslintrc"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more possible formats with extensions for e.g .eslintrc.yml, .eslintrc.js
and so forth
Would this be really needed ? |
@michael-ciniawsky imho, seems no |
👍 || 👎 on my comment above please :) |
Closing due to inactivity for now, but reopen if still relevant :) |
Similar to #23.