-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow factory to decide which props to re-use? #119
Comments
I'm not sure exactly if I understood the use-case. In your example, By "prepending an
|
I'm using Redux as well as Resolver both. I put it in the Redux store on Now, I am not sure if I should be decorating my component with connect first and then resolver, or the other way around (Let me know your opinion).
But it checks it by I am not against checking if the prop already exist, but I think it should be done within the factory. If you have a reason not to do so, then at lease we should check prop's availability by checking it to be non- Makes sense? |
The scenario makes sense to me, but, when using Redux (or any other application-state manager), React Resolver may not fit in well with it. I believe redial is the goto for this scenario. Reason being, I've personally done the "fake prop so I can dynamically change the real prop value" technique @monder has illustrated above, but I don't know that it's bringing clarity to your project vs. doing things the "redux way". I hope this helps! |
Published v3.1.0 on npm. I suppose this issue could be closed as well. |
Excellent! Thanks |
As per Resolver.js#L151, it ignores existing props.
IMO resolver should not be smart in this regard. It should be upto the developer to decide if he wants to refetch the data based on some condition or just use existing data.
I'm using Redux, and my use case is the following.
The resolve factory is never called because of
hasOwnProperty
check. Currently, I'm doing a simple workaround by prepending an_
to the prop, which seems a bit dirty solution to me.Since it already passes
props
to the factory, I would expect this check to be removed and let the factory decide if it wants to return the same data, or fetch it.Thoughts?
The text was updated successfully, but these errors were encountered: