Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to enabling flagProtection #962

Closed
ericcornelissen opened this issue Jun 17, 2023 · 1 comment · Fixed by #963
Closed

Default to enabling flagProtection #962

ericcornelissen opened this issue Jun 17, 2023 · 1 comment · Fixed by #963
Assignees
@ericcornelissen
Labels
breaking change Changes that are not backwards compatible enhancement New feature or request
Milestone
2.0.0

Comments

@ericcornelissen
Copy link
Owner

Relates to #155, #452

Summary

#908 added the flagProtection option. It added it with the default false as a default of true could be seen as a breaking change. However, flagProtection should be enabled by default in the spirit of "safe defaults" - i.e. using shescape should err on the side of caution by default.

Warning: This change would be a breaking change and require a major version bump!
@ericcornelissen ericcornelissen added enhancement New feature or request breaking change Changes that are not backwards compatible labels Jun 17, 2023
@ericcornelissen ericcornelissen added this to the 2.0.0 milestone Jun 17, 2023
@ericcornelissen ericcornelissen self-assigned this Jun 17, 2023
@ericcornelissen ericcornelissen mentioned this issue Jun 17, 2023
Merged
@ericcornelissen ericcornelissen mentioned this issue Jul 6, 2023
Merged
@ericcornelissen
Copy link
Owner Author

This was first available in 2.0.0-rc3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericcornelissen ericcornelissen

Labels
breaking change Changes that are not backwards compatible enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Start v2.0.0 ericcornelissen/shescape
1 participant
@ericcornelissen