Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What has changed in version 5.6.3? (my package no longer works) #18

Open
stla opened this issue May 2, 2024 · 5 comments
Open

What has changed in version 5.6.3? (my package no longer works) #18

stla opened this issue May 2, 2024 · 5 comments

Comments

@stla
Copy link

stla commented May 2, 2024

Hello Eric,

Since version 5.6.3, the compilation of my package cgalPolygons throws a myriad of errors: R CMD checks.

You can see that the check is ok on Windows, but the installation on Windows has downloaded version 5.6.2.

I'm not familiar with the compilation reports of C++ code but I'm under the impression the reports find some errors not in my code but in the CGAL code, that's very strange.

@ericdunipace
Copy link
Owner

Can you try using the 5.6.1 headers from the CGAL release and see if that fixes your problem. I tried to correct another users UBSAN issue, which may be the cause, but you should test your package with the CGAL release first to see if that's the issue.

@stla
Copy link
Author

stla commented May 4, 2024

Hi,

Ok I will try later.

I also got UBSAN issues with this package. I reported to the CGAL team and they told me these issues have been fixed.

@ericdunipace
Copy link
Owner

The issues are fixed in 6.0, which should be released soon; unfortunately, when I tried building my package with the master version of the CGAL headers, it caused errors in a few of the CRAN packages. Please keep me updated.

@ericdunipace
Copy link
Owner

If using the 5.6.1 version of the header files, fixes your issue, I can push a new version of the CGAL headers without my hacky UBSAN fix, probably in early June so as not to upset the CRAN mainteners. Let me know

@stla
Copy link
Author

stla commented May 15, 2024

Hello Eric,

I've tried with CGAL 5.6.1 and the R CMD checks have been successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants