This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Bug 1046485 - Move search bar out of SearchFragment #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.searchState = searchState; | ||
|
|
||
| preSearch.setVisibility(searchState == SearchState.PRESEARCH ? View.VISIBLE : View.INVISIBLE); | ||
| postSearch.setVisibility(searchState == SearchState.POSTSEARCH ? View.VISIBLE : View.INVISIBLE); |
There was a problem hiding this comment.
I think a ViewSwitcher could be helpful in this class. It would remove a few lines of code and a reference, but it would also make the intent very clear: only one of these views will be visible at a given time.
There was a problem hiding this comment.
I'll file a follow-up bug to look into this. It seems like ViewSwitchers are mainly used for animating between two different views, but it could be useful to be explicit about only ever showing one of these views. To reduce potential regressions, I think it's best to just keep the layout the same for this refactor.
|
I left some small feedback items, but overall I really like the direction of this refactoring.
Looks good :) |
leibovic
added a commit
that referenced
this pull request
Aug 5, 2014
Bug 1046485 - Move search bar out of SearchFragment. r=eedens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.