Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in 0.8, because setImmediate is not defined #78

Closed
mixu opened this issue Sep 5, 2014 · 2 comments
Closed

Doesn't work in 0.8, because setImmediate is not defined #78

mixu opened this issue Sep 5, 2014 · 2 comments
Labels

Comments

@mixu
Copy link

mixu commented Sep 5, 2014

The package.json engines field in the repo suggests it works with Node 0.8, but https://github.com/ericf/express-handlebars/blob/master/lib/utils.js uses setImmediate. setImmediate was introduced in Node 0.10.x e.g. https://github.com/joyent/node/wiki/Api-changes-between-v0.8-and-v0.10#added

This manifests as a hang when rendering on node 0.8.x + Express 3.x.

@ericf
Copy link
Owner

ericf commented Sep 5, 2014

Thanks for reporting this. I will update it to correct the engines entry in the package.json to be >=0.10.

@ericf ericf added the bug label Sep 5, 2014
@ericf ericf closed this as completed in a1864d2 Sep 5, 2014
@ericf
Copy link
Owner

ericf commented Sep 5, 2014

Published in v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants