Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Issue building Motif with Xcode 12 #101

Closed
kunal30xi opened this issue Sep 18, 2020 · 2 comments
Closed

Issue building Motif with Xcode 12 #101

kunal30xi opened this issue Sep 18, 2020 · 2 comments

Comments

@kunal30xi
Copy link

kunal30xi commented Sep 18, 2020

We are currently importing Motif 0.3.8 via Carthage
When building with Xcode 12, there is a compilation error on line 434 and line 436 of UIColor+HTMLColors.m

{
    float f = 0.0;
    if ([self scanFloat:&f]) {
        if ([self scanString:@"%" intoString:NULL]) {
            f *= 0.01;
        } else {
            f *= scale;
        }
        if (value) {
            *value = f;
        }
        return YES;
    }
    return NO;
}

Compilation error: Implicit conversion when assigning computation result loses floating-point precision: 'double' to 'float'
@kunal30xi
Copy link
Author

Pull request #102 submitted.

@kunal30xi
Copy link
Author

kunal30xi commented Sep 25, 2020

@erichoracek Any chances of getting this PR #102 merged in for this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants