Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Download #17

Closed
smaragdus opened this issue Oct 13, 2018 · 18 comments
Closed

Restart Download #17

smaragdus opened this issue Oct 13, 2018 · 18 comments

Comments

@smaragdus
Copy link

When a downloaded file has been deleted or it has been updated on the server it might be useful to have an option to restart the download- right-click on completed download- new context menu item (perhaps below 'Stop' command):

  • Restart

which just re-downloads the file. If such context menu command is implemented it might also be added to the tool bar ('Restart' button, perhaps after 'Stop' button to the right- 'Start' - 'Pause' - Stop' - 'Restart').

@erickutcher
Copy link
Owner

It's doable, but a bit involved in terms of coding. I'll keep it in mind.

@smaragdus
Copy link
Author

It's doable, but a bit involved in terms of coding.

Wouldn't such command treat the restarted download as new download just using the previously added download link and thus skipping'Add URL(s)' dialog?

Currently as a workaround I use:

  • 'Copy URL(s)' command - 'Add URL(s)' command - 'Download' command;

An option to 'Restart' download would spare the user a few clicks.

@erickutcher
Copy link
Owner

Right now if the file doesn't exist and you attempt to Open File from the menus, it'll detect it's not there and prompt you if you want to redownload it. All of that is easy. It's restarting it while it's currently downloading that's tricky. I could just only allow a restart if the download is stopped, but for completion's sake, being able to restart it at any point would be nicer. Nicer, but harder.

@smaragdus
Copy link
Author

I could just only allow a restart if the download is stopped, but for completion's sake, being able to restart it at any point would be nicer. Nicer, but harder.

From a practical point of view for me it would be fine if 'Restart' command is not active (grayed-out) when download is unfinished, paused, stopped so 'Restart' command being accessible only for completed downloads. I really do not see why should I want to restart an active download.

@smaragdus
Copy link
Author

Thank you for the tip about

The specified file was not found
Do you want to download the file again?

message. This really works like 'Restart'! I have not used 'Open File' command because I always move downloaded files from the default download directory. So 'Restart' command may have the same behaviour.

@erickutcher
Copy link
Owner

I ended up coding it to be able to restart for all states. It makes it consistent with other things and there might be someone who could use it for testing purposes. There's also a "Are you sure you want to..." prompt if it gets accidentally clicked.

@smaragdus
Copy link
Author

@erickutcher

I ended up coding it to be able to restart for all states.

I suppose it was huge work. Thank you.

A question- if a previous download is already in the list and the user adds it as a new download- shouldn't be used the previpus download from the list in stead of adding a new one at the bottom of the list?

@erickutcher
Copy link
Owner

It wouldn't be very efficient to scan the list for duplicates every time a URL is added.

The Simulate download option is a good way to do a speed test. It downloads without actually saving anything to the disk. Having the same download multiple times can show you a history of those tests.

@smaragdus
Copy link
Author

If the list of downloads is long searching for a particular download may not be fast- what about marking a download and typing a letter, for example 'h', which navigates to the next download in the list which starts with 'h'? This may facilitate search. What do you think?

@erickutcher
Copy link
Owner

A Find window could be made for a later version. Seems easy enough.

@smaragdus
Copy link
Author

A Find window could be made for a later version. Seems easy enough.

'Search' window will be fine but wouldn't it be easier just to search while typing? Or this type of search (directly through download list) would be harder to be implemented?

@erickutcher
Copy link
Owner

I've made it so that it behaves like a standard Windows listview control. That is, when you start typing something, it'll select the first item it finds in the list. The problem is that it's very rudimentary and limited to the Filename column. GTK style listviews can be searched in a similar manner and they're more thorough in searching, but I've never liked how it overlays a text box on the listview.

Having a Find window will let you search not only the Filename column, but also the URL column. You could do case sensitive/insensitive searches, and have it select multiple items in one go. It's much more versatile.

@smaragdus
Copy link
Author

I've made it so that it behaves like a standard Windows listview control. That is, when you start typing something, it'll select the first item it finds in the list.

This is exactly what I meant.

The problem is that it's very rudimentary and limited to the Filename column.

I usually need just the file name- I remember file names, not URLs.

Having a Find window will let you search not only the Filename column, but also the URL column. You could do case sensitive/insensitive searches, and have it select multiple items in one go. It's much more versatile.

This sounds fantastic although it would be needed rarely I suppose. Thank you, I wouldn't dare suggest such a complex feature which would be used seldom.

@erickutcher
Copy link
Owner

Restart, Remove and Delete, and Search are all in the new release.

@smaragdus
Copy link
Author

For me (as of version 1.0.1.0) Restart command does not work, neither when executed from context menu, nor when executed from tool bar. It triggers Are you sure you want to restart the selected entries? dialog but when I confirm nothing happens. Will you please confirm?

@erickutcher
Copy link
Owner

I tried it with a stopped, paused, and downloading download and they worked, but it's apparently not restarting completed downloads. I'll have to fix that.

@smaragdus
Copy link
Author

smaragdus commented Oct 29, 2018

I tried it with a stopped, paused, and downloading download and they worked, but it's apparently not restarting completed downloads. I'll have to fix that.

I should have mentioned that I tried to use 'Restart' command only with completed downloads.

@smaragdus
Copy link
Author

I confirm that restarting completed downloads works fine with version 1.0.1.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants