Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Download History #34

Closed
smaragdus opened this issue Nov 28, 2018 · 4 comments
Closed

Saving Download History #34

smaragdus opened this issue Nov 28, 2018 · 4 comments

Comments

@smaragdus
Copy link

This is rather a question than an issue.

If 'Enable download history' option is selected it seems that the download history is saved on program exit (if new files have been downloaded since previous session), is that true? A day ago I had to shut down the computer using the power button and the new downloads for the latest session were lost. What about every new download being immediately saved after completion in 'download_history' file?

@erickutcher
Copy link
Owner

Can't do it after each download finishes because when it saves the file it writes everything from the beginning. It would be too taxing if there's a lot of downloads.

Since the program knows when all active downloads are finished, I could have it save at that point.

@smaragdus
Copy link
Author

@erickutcher

Since the program knows when all active downloads are finished, I could have it save at that point.

I said "every download" because in most cases I download one file at a time. Updating 'download_history' file after all downloads are completed is just fine.

@erickutcher
Copy link
Owner

New version is up.

@smaragdus
Copy link
Author

@erickutcher

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants