Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would be nice to have a "hard fail" mode for the helper #41

Closed
o-smirnov opened this issue Jul 31, 2018 · 3 comments
Closed

would be nice to have a "hard fail" mode for the helper #41

o-smirnov opened this issue Jul 31, 2018 · 3 comments

Comments

@o-smirnov
Copy link
Contributor

Given my rather fiddly attempts to get js9helper going in various scenarios, I'm frequently being tripped up by the "silent fail" behaviour of JS9 when it can't connect to the helper.

At present it quietly falls back to downloading full images via HTTP. So everything continues to work, albeit more slowly and with more browser memory use. I actually have to go to the JS console to figure out if the helper is being invoked or not.

Could I ask for an option, e.g. globalOpts.requireHelper? If False (which should be the default), keep current behaviour. If True, display an error dialog if it fails to connect to the helper. Then at least if I've broken something, I'll know immediately...

@ericmandel
Copy link
Owner

I assume you want an error in two cases:

  1. if the helper does not connect
  2. if the helper connects, but fits2fits find that the js9helper program is not available

Can you think of any other cases?

@ericmandel
Copy link
Owner

JS9.globalOpts.requireHelper support is updated in GitHub (default is false).

@o-smirnov
Copy link
Contributor Author

Thanks, can confirm this option works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants