Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 compatibility #30

Open
MonsieurCellophane opened this issue May 16, 2023 · 0 comments
Open

PHP 8.0 compatibility #30

MonsieurCellophane opened this issue May 16, 2023 · 0 comments

Comments

@MonsieurCellophane
Copy link

When accessing a meeting on moodle 4.1, with php8.0, the following error is displayed:

Unsupported operand types: string * int

this is an exception thrown in mod_webexactivity\local\type\base\meeting->get_time_status() at line 408 of /mod/webexactivity/classes/local/type/base/meeting.php:

$endtime = $this->starttime + ($this->duration * 60) + ($grace * 60);

It disappears if the line is corrected thusly:

$endtime = $this->starttime + ((int)$this->duration * 60) + ((int)$grace * 60);

However, this is a clear sign that the module is not working properly in php8.0 (not surprising, as it was last updated three years ago) and that other errors like this may be lurking in the code. This makes me wonder whether compatibility will ever come, and what can be done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant