Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No DHCP for Guest Wi-Fi #931

Closed
n3vu0r opened this issue Jul 3, 2021 · 7 comments
Closed

No DHCP for Guest Wi-Fi #931

n3vu0r opened this issue Jul 3, 2021 · 7 comments

Comments

@n3vu0r
Copy link
Contributor

n3vu0r commented Jul 3, 2021

In master branch DHCP doesn't work when connecting to guest Wi-Fi. Setting up IP address, gateway, and so on manually on client side still doesn't allow connections.

@lantis1008
Copy link
Contributor

If Gargoyle is not the DHCP provider, this is currently "not a bug" and more of a feature request.

Guest wifi blocks all access to the network except for port 67 (DHCP) ans 53 (DNS) to Gargoyle ONLY.
The guest network is treated as hostile.

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Jul 4, 2021

Ah, I see. Yes, that is the case, Gargoyle is not the DHCP provider. I assume DNS is still working then as long as Gargoyle knows about DNS servers.

So, for DHCP and DHCPv6, two form inputs for an IPv4 and IPv6 address would be needed to allow discovery broadcasts of potentially hostile clients to be received only by these two whitelisted addresses? I assume ARP and NDP is not a good idea then and probably already blocked by not allowing ICMP and ICMPv6?

@lantis1008
Copy link
Contributor

Yes something like that.
Its controlled by the function here:
https://github.com/ericpaulbishop/gargoyle/blob/master/package/gargoyle-firewall-util/files/gargoyle_firewall_util.sh#L662
In particular L681 drops all forwarded traffic.
You could add some ACCEPT rules (and make sure they are in the right order so the DROP is last).

If you wanted to try that and let me know how you go, i can look at whether it can be included as a feature.

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Jul 5, 2021

Thanks, I think I understand how it works. Maybe this weekend I can try some rules.

@ektus
Copy link

ektus commented Apr 16, 2023

Discussion on the Gargoyle forum: https://www.gargoyle-router.com/phpbb/viewtopic.php?t=12249&start=10

@lantis1008
Copy link
Contributor

This was fixed as of a35af31
Please close the issue

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Apr 30, 2023

This is great, thanks!

@n3vu0r n3vu0r closed this as completed Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants