Strip trailing whitespace and newlines when not autocorrecting. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we extract the ruby code from inside the template and run rubocop on it, keeping the column positions (filling with whitespace) so that we can find where the code came from when auto correcting, most layout and style cops don't make much sense with ruumba. If we are not auto-correcting (which is experimental currently anyway), we can strip out the trailing spaces and the trailing newlines to avoid those violations. We will still get indention cop violations etc, but perhaps this at least gives a slightly better out of the box experience. Closes ericqweinstein#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we extract the ruby code from inside the template and run rubocop
on it, keeping the column positions (filling with whitespace) so that we
can find where the code came from when auto correcting, most layout and
style cops don't make much sense with ruumba.
If we are not auto-correcting (which is experimental currently anyway),
we can strip out the trailing spaces and the trailing newlines to avoid
those violations. We will still get indention cop violations etc, but
perhaps this at least gives a slightly better out of the box experience.
Closes #54