Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Title Description inconsistant to main menu #494

Closed
sivaelid opened this issue Feb 23, 2022 · 7 comments
Closed

App Title Description inconsistant to main menu #494

sivaelid opened this issue Feb 23, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@sivaelid
Copy link

Describe the issue
There are different titles used on the main pages to that used on the heading of the App page. Some are confusing, or not fully understandable as they are in not in English, where the rest of the applications are in English. The list of Bugs is below.

  1. Main menu> Tools: The heading is Utilities. Title could be Tools.
  2. Main menu> Options: The heading is Settings. The title could be Options.
  3. Main menu> Call: The heading is Search. The title in main page could be Search and ties up with Search list.
  4. Main menu > Receive>Audio: The heading is Analogue Audio. The title could be Audio.
  5. Main menu >Transmit> BHT xy/EP: Is in French not English.
  6. Main menu >Transmit> LGE Tool: Is in French not English.
  7. Main menu > Transmit> Burger Pgr: The heading is Si44XX TX. The title could be either.
  8. Main menu > Transmit> TEDI/LCR: the heading is LCR TX The title could be LCR TX.

To Reproduce
Steps to reproduce the behaviour:

  • Go to the main menu and select the items above to see the differences between the menu App title.

Expected behaviour
That the descriptions in Main, Receive or Transmit menu, match the App tittle.
That the Language of the Apps are kept the same (The most common is English).

Affected versions
Latest release (1.4.3)

Additional
That the description suggested above need to be agreed in the community.

@sivaelid sivaelid added the bug Something isn't working label Feb 23, 2022
@gullradriel
Copy link
Member

"3.Main menu> Call: The heading is Search. The title in main page could be Search and ties up with Search list."
=> except that it's not a Search app. it should be called 'Call' even in the source code, and it should be Call list.
It has already bogged me as I was doing a real 'Search' app on top of the existing Scanner. I had to rename my classses, funcs and all because the Call app is not using it's terms correctly ('Search' everywhere inside instead of 'Call').
I even proposed a PR with a correct naming scheme for the Call app. Maybe you can find it in 'closed' or 'rejected'.
I have no opinion regarding the rest of your propositions ;-)

@ArjanOnwezen ArjanOnwezen added enhancement New feature or request and removed bug Something isn't working labels Mar 20, 2022
@ArjanOnwezen ArjanOnwezen changed the title App Title Description inconsistant to main menu -bug App Title Description inconsistant to main menu Apr 10, 2022
ArjanOnwezen added a commit that referenced this issue Apr 27, 2022
@ArjanOnwezen
Copy link
Contributor

Issue resolved in ee9b4c8 . Thanks @zigad.
@sivaelid If you also want to French to English translation, please open a new ticket. It's always good to split issues/requests.

@gullradriel
Copy link
Member

gullradriel commented Apr 27, 2022 via email

@ArjanOnwezen
Copy link
Contributor

"3.Main menu> Call: The heading is Search. The title in main page could be Search and ties up with Search list." => except that it's not a Search app. it should be called 'Call' even in the source code, and it should be Call list. It has already bogged me as I was doing a real 'Search' app on top of the existing Scanner. I had to rename my classses, funcs and all because the Call app is not using it's terms correctly ('Search' everywhere inside instead of 'Call'). I even proposed a PR with a correct naming scheme for the Call app. Maybe you can find it in 'closed' or 'rejected'. I have no opinion regarding the rest of your propositions ;-)

Sorry.. missed your comment.
If it helps I'll rename the app in menu and title to Calls.

@gullradriel
Copy link
Member

gullradriel commented Apr 27, 2022

Well, what would be good would be
-sed Search by Call inside the source
-rename the files
If you want I can make a PR, but maybe @Brumi will have a word to say about that

Edit:
Just for the record, the 'Calls' app is now the 'Search' app, and using the right keyword everywhere.
I myself did rename my files and classes/funcs so there will be no conflicts if one day I merge. For those who are searching for the 'Search' app I made, it's now 'Recon' for App name and keyword for files/funcs/classes

@ArjanOnwezen
Copy link
Contributor

@GullCode that would be good.
@Brumi can also comment off course.

@ArjanOnwezen
Copy link
Contributor

@sivaelid FYI also translated the French apps in #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants