Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ImageToggle widget for 3 icons (no functional change) #1237

Merged
merged 2 commits into from Jul 5, 2023
Merged

Use ImageToggle widget for 3 icons (no functional change) #1237

merged 2 commits into from Jul 5, 2023

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Jul 5, 2023 •
edited

Use ImageToggle widget type for Mute, Speaker Disable, and Stealth icons on title bar. Saves 100 bytes. No functional change expected.

The other title bar icons had different behavior, such as 3 different states, so I didn't modify them.

@NotherNgineer NotherNgineer marked this pull request as ready for review July 5, 2023 01:53
kallanreed
kallanreed approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@kallanreed kallanreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀 beat me to it.

@gullradriel gullradriel merged commit d750afe into portapack-mayhem:next Jul 5, 2023
3 checks passed
@NotherNgineer NotherNgineer deleted the toggle branch July 5, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallanreed kallanreed kallanreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NotherNgineer @kallanreed @gullradriel