time counting fix for my last PR #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry that when i testing the changelog, i increased the time counting to see more results, and in real PR i forgot to change it back , so now it will track 50 days of change, no deadly harm
it's my stupid mistake, but if you guys agree, let's keep it once, to test if all the fallback works (since it will trace 50 days of change, long enough for a stressing test)
and if all looks good in next nightly, merge this, and all returns to normal.
but if you guys think it's not elegant, feel free to merge it now, before the nightly released.