Fix baseband thread init order bug for all procs. #1293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should hopefully address all possible baseband processor initialization race conditions.
In C++ the in-body initializers are run in declaration order. This means that the baseband_thread will start running immediately upon its declaration. This means that it will start sending data to the processor while the processor itself is still initializing which can cause all kinds of undefined behavior.
This change has two main parts.