Oversample capturing for low bandwidths #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See discussion on #1328 -- this is the same PR, but I had to push to a new branch because I had some git trouble locally. |
Brumi-2021
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Hi thanks @kallanreed .
I already evaluated deeply the previous DRAFT, see comments there, #1328
I checked also the other additional code / binary about the other combined change from @NotherNgineer about C8 ,
All seems OK , ready to be merged .
Great job, it is also preparing the needed structure for further improvements !
Cheers,
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change that @Brumi-2021 and I worked on to improve capture quality for lower bandwidth captures.
The gist of the problem is that HackRF recommends a sample rate of 2M for best results. The capture app used the bandwidth setting to compute the sampling rate, but when the bandwidth was low, the resulting sample rate was also much lower than the recommendation. For example, 20kHz bandwidth * and oversampling rate of 8 gave a sampling rate of 160kHz.
This change increases the oversampling rate from 8 to 16 for lower bandwidth captures (<25kHz) which should improve SNR and capture quality. This change could be extended to add support for higher oversampling rates in the future.
This change has been fully rebased on 'next'.