Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Select button responsiveness when updating frequency field during heavy CPU activity (e.g. WFM Audio) #1335

Merged
merged 10 commits into from Aug 1, 2023

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Jul 31, 2023

Finally fixed lingering select button responsiveness issue in WFM Audio mode (specifically when updating the frequency field which has long-press enabled) that was deferred in #1304.

For example: Prior to this change, you'll note that in Audio App, in WFM mode, if short click on Frequency that you'll need to press Done twice to close the Frequency entry screen.

@NotherNgineer NotherNgineer changed the title Resolved long-press button responsiveness issue during heavy CPU activity Resolved select button responsiveness when updating frequency field during heavy CPU activity Jul 31, 2023
@NotherNgineer NotherNgineer marked this pull request as ready for review July 31, 2023 23:34
@NotherNgineer NotherNgineer changed the title Resolved select button responsiveness when updating frequency field during heavy CPU activity Fixed Select button responsiveness when updating frequency field during heavy CPU activity (e.g. WFM Audio) Aug 1, 2023
Copy link
Contributor

@kallanreed kallanreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NotherNgineer NotherNgineer merged commit 06b7a04 into portapack-mayhem:next Aug 1, 2023
3 checks passed
@NotherNgineer NotherNgineer deleted the debounce branch August 1, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants