Add Gain_TX control to the Replay App #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Replay App , shows in the user menu a UI to select two kind of controls for the RF output level : 1-) LNA GAIN (0..40 ) dB => but it has no TX effect because it is the RX-LNA . GAIN 2-) RF AMP (0 / +14dBm , (that was correct , we have two IC's , RX / TX ) (sw is controlling weill . Note, although SW Version 1.40 do not leave to control drictly the GAIN TX , that Replay App , in fact, it was using the inheritated selected GAIN TX from any previous usage of MIC App. That Pull request alllows now to have the following controls 1-) GAIN TX (0..47 ) dB (now it is OK 2-) RF AMP (0 / +14dBm , (that was correct , we have two IC's , RX / TX ) (sw is controlling weill . Remakrs : After the change , now we can control the GAIN TX , but not "in the fly" . When we are in the Replay loop , any change of the FREQUENCY or GAIN TX will be ignored , till we play STOP / START the loop again. (but the AMP RF (0 /+14 dBs) it works in the loop withouth any problems (same as before ) .
Brumi-2021
added a commit
to Brumi-2021/portapack-mayhem
that referenced
this pull request
Dec 5, 2021
…TX to Replay App
eried
added a commit
that referenced
this pull request
Jan 12, 2022
…s_RF_tx-rx_amp” Minor improvements to the previous PR #395 Add Gain_TX to Replay App
Brumi-2021
added a commit
to Brumi-2021/portapack-mayhem
that referenced
this pull request
Jan 29, 2022
Add Gain control to the GPS Sim App . (we are clonning the two previous PR's n portapack-mayhem#395 and portapack-mayhem#446 of the Replay App, correcting TX Gain control to this GPS Sim App )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Replay App SW V1.40 , shows in the user menu a UI to select two kind of controls for the RF output level :
1-) LNA GAIN (0..40 ) dB => but it has no TX effect because it is the RX-LNA . GAIN
2-) RF AMP (0 / +14dBm , (that was correct , we have two IC's , RX / TX ) (sw is controlling well .
Note, although currrent SW Version 1.40 do not leave to control directly the GAIN TX
, that Replay App , in fact, it was using the inheritated selected GAIN TX from any previous usage of MIC App.
That Pull request alllows now to have the following controls
1-) GAIN TX (0..47 ) dB (now it is working well )
2-) RF AMP (0 / 1 ) means , 0dB's , +14dBs , (that was correct , we have two IC's , RX / TX ) (sw was alrady controlling them well .
Remakrs :
i-) After the change , now we can control the GAIN TX , but not "in the fly" . When we are in the Replay loop , any change of the FREQUENCY or GAIN TX will be ignored , till we play STOP / START the loop again. (but the AMP RF (0 /+14 dBs) it works in the loop withouth any problems (same as before ) .
ii-) By default , initial TX settings I left , GAIN_TX = 35 , RF AMPLIFER "0" . (that means low power initial default data to avoid any damage if not correct antenna matching ) , but it can be changed very easily . (maximum RF radiatted power , GAIN_TX = 47 , RF AMPLIFER "1") ,
iii-) In the UI , before appears "LNA:" , as I had no space , now I am using "GAIN" (without ":" , apologize , no space )
iv-) testing it , I could find another small bug , that it was already exisiting in the original Replay App, (but it wil be sorted in next feature ) ==> while we are transmitting the recorded file, and we toggle RF amp (0 <-->1) , the TX LED is swithced off in the the "0" value, but it is not correct becasuse, in the loop tx, we are still in TX mode. (just with lower gain ) (very small issue to be addressed later.)