Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor GUI change Capture App : Change "REC" icon background colour from black -> yellow , BW Options >600Khz #438

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

Brumi-2021
Copy link
Contributor

@Brumi-2021 Brumi-2021 commented Nov 28, 2021

That PR is linked to the previous one #433 (it is a MINOR GUI change)
We are changing "REC" icon background colour from black -> yellow , ONLY in the BW Options of the Capture App, where the current FW is applying decimation to the recorded micro SD Card file ,( that means BW user-selection , >600Khz) :

1-) we leave , the "REC" icon , background colour as it was original (black) in all the BW OPTIONS of the Capture App,
where the recorded file .C16 , has a full real rate sampling , that means (BW <= 600Khz : 8k5, 11k, 16k, 25k, 50k, 100k, 250k, 500k, 600k) Those .C16 recorded files, can be used, as usual , with the Replay App.

2-) We just change the background colour of the "REC" icon , from black -->yellow in the rest of the BW OPTIONS of the Capture App, where the recorded file .C16 is decimated , and therefore has NOT the full real I,Q real rate samples . BW user_selection .>600Khz ; : 750k, 1100k, 1750k, 2000k, 2500k, 2750k ). Those recorded files are still valid to see the spectrum shape, ..., by Inspectrum , or Audacity sw tool ,...but as they do not have all the sampled data (becasuse they are decimated) , they are NOT valid to be used in the Replay App, (that is why we indicate in the GUI, to not confuse to the user)

Example,
image

(as I was comment in the previous PR #413 )
image

(It is pending to be investigated in next weeks , if we can also manage to capture BW 750Khz, and 1Mhz with fast micro SD Cards -with low random lattency , and changing that FW decimation threshold point .)

@eried
Copy link
Member

eried commented Nov 28, 2021

Nice idea. I am not thinking if there is a better way (maybe next to the "k" since we have space). Just wondering how confusing will be for users to see a yellow rec button 😸

@Brumi-2021
Copy link
Contributor Author

Hi , I tried to make a simple code change , and at the same time visible 100% to the user , telling him that something is different . No doubt , that this yellow background icon , will be noticed by everyone .

But I agree with you , that just the colour change alone , will not suggest to the user , the current behind recording limitations .I think that soon or later we will need to add it’s explanation in our wiki Mayhem Apps area .

Of course that we can also add any letter after the “k“, (maybe we may need to change 5 chars to 4 : ´2750k´ to ´2,75M´) ., but maybe we will have similar problem .

Eventually , we can block to the user , the recording to the microSD option , about those decimated files. (It Is up to us ) , but definitely, in my opinion , it is a nice feature , at least keep it , In the LCD screen ( to see spectrum BW > 600khz .)

@ArjanOnwezen
Copy link
Contributor

Yeah or hide it from users by a menu option in options by using a boolean in persistent storage. So at least it's a decision by the user.

@eried eried merged commit c3da286 into portapack-mayhem:next Nov 29, 2021
@eried
Copy link
Member

eried commented Nov 29, 2021

If someone asks, then we need to add it to the wiki 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants