Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the previous PR #395 Add Gain_TX to Replay App #446

Conversation

Brumi-2021
Copy link
Contributor

This PR , is an an update of the previous one #395,
about Replay App , correcting two several minor issues. (inspired with the job of Mic App contributors . Thanks !!!)

Before talking about the MINOR IMPROVEMENTS, let me share the updated previous frontend RF chart.,
where I added more details , showing now :
usual fw code ref. var labels //adj. margin range // adj. steps // and usual LCD GUI labels.

image

MINOR IMPROVEMENTS :
1-) In previous code , any RX(rf_amp) user setting modification (in any receiver App ) ,
was modifying at the same time the TX (rf_amp) in Replay App and viceversa. (that might be sometimes confusing and annoying ). (That is not happening in the rest of TX App like ex. Mic App) . Then, this has been addressed in this PR

2-) In previous code , while we were in play mode , we could modify “in real time” the TX (rf_amp) (that was good ) , but the TX LED was following that rf_amp toggle setting (that was incorrect) because while we are in play mode, we were always in TX mode. (so TX_LED should be constant in ON while we are transmitting the file ).This has been addressed in this PR, but now , it is ignored any "live changes " of tx-freq, tx-gain . tx-rfamp, till next "stop" and "play" or next automatic "loop" .

3-) This time we also communized the TX rf_amp GUI interface , (0 / 14 dBs gain) , same as Mic App .

Note :
same as before ,
i-) to avoid any RF amplifier IC , 14dB’s, accidental damage (if user has no antenna connection or antenna missmatching ) - , the first “play” will not use max radiation antenna power . The initial values are (GAIN =35 (-12dB's max) , TX(rf_amp) = 1 =+14dB's) , but of course after first “stop”, any other adj. of freq. / GAIN /, rf_amp, …, will be applyied at every new “play” or new “automatic loop” . (so user will be able to put in max , but not the initial "play")

CONFIRMATION
I checked in three RECEIVER App's , (ex. in ADSB- App ,, or Capture App , or Audio receiver ) that now , any RX_AMP setting is independent from the selected TX_AMP in the Replay App. (I did not check all, but i believe that all are now ok).

@Brumi-2021 Brumi-2021 changed the title Minor improvementes to the previous PR #395 Add Gain_TX to Replay App Minor improvements to the previous PR #395 Add Gain_TX to Replay App Dec 5, 2021
@eried eried merged commit e5015cc into portapack-mayhem:next Jan 12, 2022
Brumi-2021 added a commit to Brumi-2021/portapack-mayhem that referenced this pull request Jan 29, 2022
Add Gain control to the GPS Sim App .
(we are clonning the two previous PR's n portapack-mayhem#395 and portapack-mayhem#446 of the Replay App, correcting TX Gain control to this GPS Sim App )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants