Mic App: DSB RX distortion c/m + minor improv. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MINOR CORRECTIONS and IMPROVEMENTS to RX of the MIC -APP)
In previous fw PR #727 , I could realise that the audio demodulated of the MOD: DSB reception, was distorted.
After debugging and testing I could confirm that I wrongly activated RX AM DSB-C (with carrier) demodulation, but when we transmit a signal AM suppressing the carrier , (DSB-SC) actually it was just decoding incorrect distorted audio.
With this minor PR , we apply following minor changes, :
i-) To avoid missunderstanding , and be more accurate , we changed in the main MOD Types label : DSB label --> DSB-SC (previous label : DSB was to general better specify that in that mode we are really TX DSB-SC, because actually in that mode , we are transmitting both lateral side bands , but with suppressed central carrier .
ii-) Add in the below RX part ,when we activate the MOD : DSB-SC , in the below submenu, the user will have the choice to select the lateral demod. part , USB or LSB.
iii-) I am removing in below line the "FM" word, "FM RXBW" --> "RXBW", and now we are displaying the selected reception bandwith of each selected mode. (in all modes, not only FM ) .
iv-) Other minor GUI issues, adding 1,2 in the RXBW labels that has several options, example NFM1, NFM2, SSB1, SSB2, then user can better recognise wich MODES has additional RX sub-options or not .
v-) some internal code comments corrections , and code improvements.
I already validated in both platforms , AK4951 H1 , WM8731 H2+ , transmitting AM /DSB-SC / USB / LSB from GNURADIO.
Cheers,