You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should the compute_reward function be made a more general way so we can have different block rewards for different rule_set or at least make sure we only count rewards when using ethash?
The text was updated successfully, but these errors were encountered:
There some inconsistency when calculating block rewards. e.g. in https://github.com/erigontech/silkworm/blob/29b40fc5c4a8039503b7dd3912ebd8c1efd2202e/silkworm/rpc/commands/erigon_api.cpp#L496C3-L496C3
The reward is only calculated when using ethash: (chain_config.config.count("ethash") != 0)
but in
silkworm/silkworm/rpc/core/evm_trace.cpp
Line 1220 in 29b40fc
The reward is computed regardless.
Should the compute_reward function be made a more general way so we can have different block rewards for different rule_set or at least make sure we only count rewards when using ethash?
The text was updated successfully, but these errors were encountered: