Make sure FLAC__stream_encoder_init_stream() is only called once. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FLAC__stream_encoder_init_stream() function complains if it is called multiple times. If we happen to have flushed the header manually before with sf_command(snd, SFC_UPDATE_HEADER_NOW, ...) .. then all subsequent sf_write...() functions fail otherwise because they attempt to write the header again.
|
This is my localized approach to solve the problem I encountered ( |
Explicitly writing the header with SFC_UPDATE_HEADER_NOW before the first sf_write() was making sf_write() calls fail. This is a test to verify that the fix works.
|
Alright, also added test that fails without the patch in the first submit and passes with the patch (and in a subsequent submit fixed that the test should only be run when FLAC is compiled in). If you merge this via github, then the 'squash and merge' option is probably the best to only end up with a single commit. |
|
Merged manually. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FLAC__stream_encoder_init_stream() function complains if it is
called multiple times. If we happen to have flushed the header
manually before with
sf_command(snd, SFC_UPDATE_HEADER_NOW, ...)
.. then all subsequent sf_write...() functions fail otherwise because
they attempt to write the header again.