Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockest does not work with docker-compose V2 #283

Closed
oscarlgz opened this issue Jan 31, 2022 · 7 comments · Fixed by #284
Closed

Dockest does not work with docker-compose V2 #283

oscarlgz opened this issue Jan 31, 2022 · 7 comments · Fixed by #284

Comments

@oscarlgz
Copy link

Describe the bug

docker-compose V2 config command omits version from output. dockest cannot run as when validating compose file(s) it expects version to be present.

Skärmavbild 2022-01-31 kl  12 09 47

See this issue for reference.

I'm not sure what would be the best way to remedy this. Possibly just remove the version check in this line.

@erikengervall
Copy link
Owner

Indeed, ran into this myself recently. I'll give it some though - might release a temporary patch just to get things working again while working on a proper solution.

@oscarlgz
Copy link
Author

oscarlgz commented Feb 2, 2022

That would be nice 👍

@erikengervall
Copy link
Owner

@oscarlgz give v3.0.1 a try when you've got a chance

works pretty well on my end

@oscarlgz
Copy link
Author

oscarlgz commented Feb 3, 2022

Works here! Thanks 🎉

@celiolatorraca
Copy link

celiolatorraca commented Mar 21, 2022

Hey!

Bumping to version 3.0.1 solved the version issue, but now it seems that docker-compose reads the published ports as string and dockest expects it to be integer

Are you having this issue?

v1 output:

postgres:
    environment:
      POSTGRES_DB: ...
      POSTGRES_PASSWORD: ...
      POSTGRES_USER: ...
    image: ...
    ports:
    - published: 5434
      target: 5432

v2 output:

postgres:
    environment:
      POSTGRES_DB: ...
      POSTGRES_PASSWORD: ...
      POSTGRES_USER: ...
    image: ...
    networks:
      default: null
    ports:
    - target: 5432
      published: "5434"

@celiolatorraca
Copy link

We tried in 2 different version os docker-compose.

On version 2.2.3 the published port comes as an integer,
But on version 2.3.3 it comes as a string

Should we maybe accept both integer and string?

@erikengervall
Copy link
Owner

We tried in 2 different version os docker-compose.

On version 2.2.3 the published port comes as an integer, But on version 2.3.3 it comes as a string

Should we maybe accept both integer and string?

Sounds like a good idea 👍

Will create a new issue referencing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants