Merge d5ff65e into ff37cba

.byebug_history

@@ -0,0 +1,23 @@
+c
+@opt.instance_variable_get(:@switches)["--foo"].default
+@opt.instance_variable_get(:@switches)["--foo"]
+@opt.instance_variable_get(:@switches)
+@opt.instance_variable_get(:@switches).default
+c
+@opt.instance_variable_get(:@switches).default
+@opt.instance_variable_get(:@switches)
+@opt.instance_variable_get(:@switces)
+@opt.switches
+@opt
+exit
+@opt.switches
+@opt.instance_variables
+@opt.assigns
+@opt
+@opt.switch
+@opt.switches
+@opt
+exit
+self
+foo
+:foo

lib/thor/parser/arguments.rb

@@ -30,7 +30,12 @@ def initialize(arguments = [])
 
       arguments.each do |argument|
         if !argument.default.nil?
-          @assigns[argument.human_name] = argument.default
+          begin
+            @assigns[argument.human_name] = argument.default.dup
+          rescue TypeError  # Compatibility shim for un-dup-able Fixnum in Ruby < 2.4
+            @assigns[argument.human_name] = argument.default
+            next
+          end
         elsif argument.required?
           @non_assigned_required << argument
         end

spec/parser/options_spec.rb

@@ -302,11 +302,10 @@ def remaining
             "Expected '--fruit' to be one of #{enum.join(', ')}; got orange")
       end
 
-      it "allows multiple values if repeatable is specified" do
-        create :foo => Thor::Option.new("foo", :type => :string, :repeatable => true)
-
+      it "can does not erroneously mutate defaults" do
+        create :foo => Thor::Option.new("foo", :type => :string, :repeatable => true, :required => false, :default => [])
         expect(parse("--foo=bar", "--foo", "12")["foo"]).to eq(["bar", "12"])
-        expect(parse("--foo", "13", "--foo", "14")["foo"]).to eq(["bar", "12", "13", "14"])
+        expect(@opt.instance_variable_get(:@switches)["--foo"].default).to eq([])
       end
     end