Remove some variable and method redefinition warnings

rails · May 19, 2012 · ea412cd · ea412cd
1 parent 2373c1f
commit ea412cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/thor/group.rb b/lib/thor/group.rb
@@ -180,7 +180,7 @@ def get_options_from_invocations(group_options, base_options) #:nodoc:
         end
         next unless value
 
-        klass, task = prepare_for_invocation(name, value)
+        klass, _ = prepare_for_invocation(name, value)
         next unless klass && klass.respond_to?(:class_options)
 
         value = value.to_s

diff --git a/lib/thor/shell/basic.rb b/lib/thor/shell/basic.rb
@@ -3,7 +3,8 @@
 class Thor
   module Shell
     class Basic
-      attr_accessor :base, :padding
+      attr_accessor :base
+      attr_reader   :padding
 
       # Initialize base, mute and padding to nil.
       #
@@ -147,7 +148,7 @@ def print_table(array, options={})
         start.upto(colcount - 1) do |index|
           maxima = array.map {|row| row[index] ? row[index].to_s.size : 0 }.max
           maximas << maxima
-          if index == colcount -1
+          if index == colcount - 1
             # Don't output 2 trailing spaces when printing the last column
             formats << "%-s"
           else