New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore old check on `completion_proc=` #690

Merged

rafaelfranca merged 1 commit into rails:master from deivid-rodriguez:rb_readline_does_not_respond_to_call

Nov 11, 2019

Contributor

deivid-rodriguez commented Nov 11, 2019 •

edited

When dropping 1.8.7 support, I blindly removed this check, because the comment above it suggested that it was 1.8.7-specific.

However, the check is also needed for rb-readline, the default readline implementation on modern rubies under Windows. See https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/readline.rb#L91-L97.

So, I'm restoring the check, and the specs changes that I included in the 1.8.7 support drop commit to get specs passing.


          Restore old 1.8.7 check on completion_proc=

fe3c930

`rb-readline`, the default readline implementation that currently comes
with Windows, does not allow `nil` to be passed in here because it
doesn't respond to `call`. See: https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/readline.rb#L91-L97

deivid-rodriguez changed the title ~~Restore old 1.8.7 check on completion_proc=~~ Restore old check on completion_proc=

rafaelfranca merged commit 45b95a3 into rails:master

deivid-rodriguez deleted the rb_readline_does_not_respond_to_call branch

November 11, 2019 20:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment