Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork postcss-import #2

Open
leebenson opened this issue Apr 24, 2017 · 5 comments
Open

Fork postcss-import #2

leebenson opened this issue Apr 24, 2017 · 5 comments

Comments

@leebenson
Copy link
Contributor

On reflection, I think it'd make more sense to fork and PR and postcss-import vs building a home-brew version.

postcss-import has a lot of functionality out-the-box, including duplicate detection and proper handling of paths and external resources. The only thing it's missing is an option to disable top-level @import checking, and concatenate in place.

It would probably make more sense to add an option for disabling top-level enforcement of imports and submit a PR than building something separate.

What do you think @eriklharper?

@leebenson
Copy link
Contributor Author

the feature has already been suggested by one of the maintainers there, btw (postcss/postcss-import#214 (comment)) -- just hasn't been done yet.

@eriklharper
Copy link
Owner

I totally agree, I think its silly to reinvent the wheel of what's already been built.

@dehuszar
Copy link

dehuszar commented Jan 7, 2018

Is this refactor still planned? I have need of this plugin as a dependency to my own, due to postcss-import's spec-strictness.

@Akimyou
Copy link

Akimyou commented Jan 7, 2020

See this issue. It seems postcss-import no want to support css scoped nested import.

postcss/postcss-import#296

@revelt
Copy link
Collaborator

revelt commented Feb 10, 2022

We've just released v0.2.0. Does anybody object if we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants