Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGAN implementation error #47

Closed
marued opened this issue Apr 16, 2019 · 3 comments
Closed

WGAN implementation error #47

marued opened this issue Apr 16, 2019 · 3 comments

Comments

@marued
Copy link

marued commented Apr 16, 2019

In your WGAN implementation, you have your n-critique loop around the Generator learning when it should actually be around the Discriminator's. Critique stands for Discriminator.

@eriklindernoren
Copy link
Owner

eriklindernoren commented Apr 16, 2019

The paper tells us that we should train the critic (discriminator) n_critic times for each generator update, just as WGAN is implemented here. The discriminator is updated on each batch but the generator is only updated every n_critic batch.

@marued
Copy link
Author

marued commented Apr 20, 2019

A yes, sorry! I read too quickly and mistook the 'If' in the code for a 'for' loop.

@eriklindernoren
Copy link
Owner

No problem! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants