Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero_corr_max_peak makes strange empty samples at the end of the profile #6

Open
erikmannerfelt opened this issue Jun 6, 2023 · 0 comments
Labels
invalid This doesn't seem right

Comments

@erikmannerfelt
Copy link
Owner

zero_corr_max_peak leaves/appends strange values at the end of a profile when run. I assume that this has to do with that a new array is constructed with only zeros:

let mut new_data = Array2::from_elem(

.. and then it may not be trimmed at the end correctly.

Here's the end of a radar profile without zero-corr:
image

And here it is with zero_corr_max_peak:
image

The fix may be as simple as just trimming the data correctly. I also think there's a zero-copy way of doing this instead of instantiating an entirely new array. Finally, a test should be added to make sure this does not happen!

@erikmannerfelt erikmannerfelt added the invalid This doesn't seem right label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant