Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React simple router and AsyncProps #831

Closed
sars opened this issue Jan 15, 2016 · 9 comments
Closed

React simple router and AsyncProps #831

sars opened this issue Jan 15, 2016 · 9 comments

Comments

@sars
Copy link
Contributor

sars commented Jan 15, 2016

I'd propose to migrate to React simple router and AsyncProps (it replaces connectData)
I've already moved to this stack on my project and satisfied so far.

If you want - I can try to make PR for this project as well

@svrcekmichal
Copy link

@sars can you create PR? Trying to do that a while to fit my use case, it would be awesome to look at working example 👍

@asaf
Copy link

asaf commented Jan 15, 2016

+1

If you create a PR, I suggest it to be minimal and clean as possible (last PRs about this subject became too fat).

Related to: #685 , #611

@sars
Copy link
Contributor Author

sars commented Jan 15, 2016

https://github.com/erikras/react-redux-universal-hot-example/pull/833/files

@asaf, @svrcekmichal Something like this... Hope it's not too big

@sars
Copy link
Contributor Author

sars commented Jan 15, 2016

waiting for ryanflorence/async-props#42

@alex88
Copy link

alex88 commented Jan 16, 2016

Uh this seems to remove quite some code! I'm trying to build a client-side-only version of this "boilerplate" and it helps a lot to make it simpler!

@sars
Copy link
Contributor Author

sars commented Jan 20, 2016

@erikras , please, have a look:
#531 (comment)

Do you like this idea?

@erikras
Copy link
Owner

erikras commented Jan 20, 2016

👍🏻 I do.

@quicksnap
Copy link
Collaborator

Can we close this in favor of #833?

@erikras
Copy link
Owner

erikras commented Jan 20, 2016

@sars says he's gonna do redo #833 better. #833 (comment) I say close 'em both in favor of his new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants