Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V6 alpha 13] - Re-render still occurs on the entire form component #1031

Closed
peterpme opened this issue May 23, 2016 · 5 comments
Closed

[V6 alpha 13] - Re-render still occurs on the entire form component #1031

peterpme opened this issue May 23, 2016 · 5 comments

Comments

@peterpme
Copy link

peterpme commented May 23, 2016

Hey,

The work you've been doing for redux-form V6 has been amazing! Thanks 馃憤

I did notice however that the entire form is still being re-rendered on key press. I've attached a screenshot below of the example project for reference:

http://redux-form.com/6.0.0-alpha.13/examples/simple/

Thanks again!

re-render

@peterpme peterpme changed the title [V6 alpha 13] - Re-render still occurs on the entire form componen [V6 alpha 13] - Re-render still occurs on the entire form component May 23, 2016
@erikras
Copy link
Member

erikras commented May 23, 2016

What makes you think the whole form is being rerendered? And what's up with those funky colors?

@peterpme
Copy link
Author

peterpme commented May 23, 2016

Hey, sorry for the lack of context! I'm using react-devtools in Chrome.

When you click trace React updates it'll automatically highlight the selections that are being updated!

https://github.com/facebook/react-devtools

@erikras
Copy link
Member

erikras commented May 23, 2016

Ooh!! That's new to me. Thanks!

However, you are confusing updates with renders. Yes, the form component does receive new props on every keypress, but it does not re-render.

@erikras erikras closed this as completed May 23, 2016
@peterpme
Copy link
Author

Ah cool, thanks!

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants