Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot testing in my project getting failed after upgrading to v7.2.1 #3771

Closed
sharvit opened this issue Jan 21, 2018 · 2 comments
Closed

Comments

@sharvit
Copy link

sharvit commented Jan 21, 2018

Bug report

After upgrading from v7.2.0 to v7.2.1 one of our snapshot testings in foreman is getting failed.

Test result:
https://travis-ci.org/theforeman/foreman/jobs/330761776#L4877

Test code:
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/bookmarks/form/form.test.js#L35

I am still investigating how the upgrade is affecting my project, but, nothing is getting break when running the app, only when running tests with jest.

Are there any breaking changes in this patch?

  • I can see you migrated from return error to throw error in this version, can it be the reason?

What's your environment?

Travic CI

node versions: v8, v6.10, v6

Fedora

node version 8 (lts)

Thanks!

@gustavohenke
Copy link
Collaborator

Can you test with newer versions?

Also please take into account that a patch update means a bug fix.
If a prop value was incorrect because of bug, then we can't do nothing about it. We wouldn't release a major version because a bug was fixed and a prop value changed.

@lock
Copy link

lock bot commented Mar 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants