Add optional arguments for side_effect() #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I persuaded myself; this PR now just adds the |
erikrose
reviewed
Feb 23, 2017
| >>> f = StringIO() | ||
| >>> func = lambda x: print(x, file=f) | ||
| >>> it = [u'a', u'b', u'c'] | ||
| >>> consume(side_effect(func, it, file_obj=f)) |
There was a problem hiding this comment.
I think we ought to change file_obj to file for brevity. That was going to be my only reason, but look at the print call just above: file=. So, consistency, too. :-) What do you think?
There was a problem hiding this comment.
file is the name of a built-in in Python 2, otherwise I would have done that.
There was a problem hiding this comment.
But as a kwarg, it doesn't collide with names: it's more akin to a dictionary key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: PR #112, this adds some new optional keyword arguments to
side_effect().Previously the function passed in was only allowed to accept a single argument. It now must accept an item from the iterable as the first argument, and a fixed set of other arguments can be passed in. Additionally, keyword arguments can be specified.Also added is
file_obj, which is a hint that the function will operate on a file object that should be closed after iterating. See the tests, docstring, and the older PR for motivating use cases.I could be persuaded to get rid of the argument / keyword argument and just give examples with lambdas or partials. Anybody feel strongly?Many thanks to @yardsale8 for the suggestion.