integer and set partitions #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bbayles
requested changes
Jul 11, 2019
There was a problem hiding this comment.
Many thanks for this PR.
I think the integer_partitions I would rather leave out, since it only applies to iterables of integers. I have used a similar algorithm (this one), but I think it's slightly outside the scope of more-itertools.
set_partitions looks like a good inclusion.
Could I ask you to (1) drop integer_partitions, (2) add tests for set_partitions?
Thanks again.
bbayles
reviewed
Jul 12, 2019
more_itertools/more.py
Outdated
| def set_partitions(iterable, k=None): | ||
| """ | ||
| Generates k set partitions of iterable, or all partitions if k is not given | ||
| A set partition is a wasy to split a set into unique subsets that when |
There was a problem hiding this comment.
Suggested change
| A set partition is a wasy to split a set into unique subsets that when | |
| A set partition is a way to split a set into unique subsets that when |
|
Closes #296. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements lexically-ordered integer and set partitions generators. The generators can generate only k-partitions, or if no k is given, it will generate all number of partitions.