Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS inclusion #1

Open
erikw opened this issue Aug 7, 2021 · 1 comment
Open

Improve CSS inclusion #1

erikw opened this issue Aug 7, 2021 · 1 comment
Labels
feature New Feature Request

Comments

@erikw
Copy link
Owner

erikw commented Aug 7, 2021

Status quo

It would be desirable to improve the way CSS for the tooltip is used with this plugin. Currently the user have to copy the CSS file and include it themselves in the page. I'm creating this issue here to maybe get some input from other's on how we could do this.

Pros:

  • Users can easily override and completely restyle the tooltip
  • Users can integrate the CSS with whatever solution they have like a global main.css with minification, or SASS setup.

Cons:

  • More work to set up the plugin
  • More work to keep the plugin up-to-date when new versions (of the CSS file) is committed to the plugin

Desired state

  • By default, CSS is included in the generated pages with no additional steps needed by the user, other than enabling the plugin and using the glossary tag
  • Still allowing the user to completely restyle the CSS (replace or override)

Solution ideas

@erikw erikw added the feature New Feature Request label Aug 7, 2021
@badosu
Copy link

badosu commented Feb 11, 2023

We are using this plugin to host a fork of Spring called Recoil (site).

Currently we vendor the css into a custom sass file included by just-the-docs.

Of course it would be optimal to automatically compile the css asset on the build process for serving and include the tag automatically when a glossary term is used inside a page, although unclear if jekyll is able to support this.

Thanks for creating this plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants