OnItemClickListener & OnItemLongClickListener

[jonathan-caryl]

Our ListView uses OnItemClickListener to switch to a detail view, and OnItemLongClickListener to reveal a button in the ListView item. I've switched to a PullToRefreshListView, and I find I still get these listeners firing when I'd expect the view to be consuming the touch events as part of the pull-to-refresh functionality. E.g. press and slowly move down, we start to reveal the 'pull to refresh' row at the top of the list, but we then get our OnItemLongClickListener called. Or pull down swiftly for 1/2 a row, again we see the 'pull to refresh' start to be displayed, but if you then release the touch we get the OnItemClickListener called.

This feels wrong, I'd expect to have these Listeners called only if we're not doing any pull to refresh action. Is this how it's meant to work? Or is there some way I can configure it to behave the way we need?

[erikwt]

You're right, this is not the way it's supposed to work.

What revision are you using? The latest 'master' or are you on the 'development' branch?

[jonathan-caryl]

I'm using 'master'.

I've not completely figured out how the code works, but I see in PTROnItemClickListener and PTROnItemLongClickListener it checks that the state is PULL_TO_REFRESH before it fires the listener, but if you're just at the point of dragging the list down to reveal the 'pull to refresh' bit at the top, then that's what the state will be. Perhaps there needs to be another state, which indicates the user's dragging, but we're still showing 'pull to refresh'?

[vibu]

I also had the problem with Click and LongClick listeners with PullToRefreshListView. I have made some modifications and now it works fine. Hope it helps. Might also be helpful for issue #25 :

file: PullToRefreshListView.java
...

float mScrollStartY;

    @Override
    public boolean onTouchEvent(MotionEvent event){
        if(lockScrollWhileRefreshing
                && (state == State.REFRESHING || getAnimation() != null && !getAnimation().hasEnded())){
            return true;
        }

        switch(event.getAction()){
            case MotionEvent.ACTION_DOWN:
                if(getFirstVisiblePosition() == 0) {
                    previousY = event.getY();                   
                }
                else previousY = -1;
                //+++
                mScrollStartY = event.getY();
                //+++
                break;

            case MotionEvent.ACTION_UP:
                if(previousY != -1 && (state == State.RELEASE_TO_REFRESH || getFirstVisiblePosition() == 0)){
                    switch(state){
                        case RELEASE_TO_REFRESH:
                            setState(State.REFRESHING);
                            bounceBackHeader();

                            break;

                        case PULL_TO_REFRESH:
                            resetHeader();
                            break;
                    }
                }
                break;

            case MotionEvent.ACTION_MOVE:
                if(previousY != -1 /*+++*/&& Math.abs(mScrollStartY-event.getY()) > 5 /*+++*/){
                    float y = event.getY();
                    float diff = y - previousY;
                    if(diff > 0) diff /= PULL_RESISTANCE;
                    previousY = y;

                    int newHeaderPadding = Math.max(Math.round(headerPadding + diff), -header.getHeight());

                    if(newHeaderPadding != headerPadding && state != State.REFRESHING){
                        setHeaderPadding(newHeaderPadding);

                        if(state == State.PULL_TO_REFRESH && headerPadding > 0){
                            setState(State.RELEASE_TO_REFRESH);

                            image.clearAnimation();
                            image.startAnimation(flipAnimation);
                        }else if(state == State.RELEASE_TO_REFRESH && headerPadding < 0){
                            setState(State.PULL_TO_REFRESH);

                            image.clearAnimation();
                            image.startAnimation(reverseFlipAnimation);
                        }    
                        // +++ return true;
                    }         
                    //+++                               
                    return super.onTouchEvent(event);
                    //+++
                }

                break;
        }

        return super.onTouchEvent(event);
    }

...

private class PTROnItemLongClickListener implements OnItemLongClickListener{

        @Override
        public boolean onItemLongClick(AdapterView<?> adapterView, View view, int position, long id){
            hasResetHeader = false;

            //+++if(onItemLongClickListener != null && state == State.PULL_TO_REFRESH){
                //+++ Passing up onItemLongClick. Correct position with the number of header views
                return onItemLongClickListener.onItemLongClick(adapterView, view, position - getHeaderViewsCount(), id);
            //+++}

            //+++return false;
        }
    }

[erikwt]

Hi @vibu,

That looks promising. Would you make it a commit & pull request so I can test it out and possible merge it in?

Thanks in advance,
Erik

[lechon]

This code seems to work fine for me, I'm happy using it.
Thanks.
Jose M¬

[erikwt]

I tested the code in development and master, merged in both. Thanks @vibu!