Check for full inventory missing

[Peda1996]

Hy,

I really like your plugin, but when an inventory is full, trading is possible. But after the trade, the traded items are gone, due to a full inventory. (dropping wont work for my, dont know why..)

Please add a check for this.
Reguards
Peda1996

[erikzimmermann]

Hey, thanks for your bug report via GitHub. I will add a option there, to cancel a trade then in the config.yml ;)

[Peda1996]

Thanks mate :D

[Peda1996]

Can you please provide a .jar download, as I can't compile it on my own.

I started to create a pom.xml (maven, i really recommend it), and afterwards i started to realize, that CodingAPI has no repo ^^
There is my pom.xml.

 <?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>de.codingair</groupId>
    <artifactId>TradeSystem</artifactId>
    <version>1.0.5</version>
    <packaging>jar</packaging>
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <maven.compiler.source>1.8</maven.compiler.source>
        <maven.compiler.target>1.8</maven.compiler.target>
    </properties>
    <name>TradeSystem</name>
    <description>Bukkit/Spigot - Trade - Plugin</description>
    <repositories>
        <repository>
            <id>spigot-repo</id>
            <url>https://hub.spigotmc.org/nexus/content/repositories/snapshots/</url>
        </repository>
        <repository>
            <id>vault-repo</id>
            <url>http://nexus.hc.to/content/repositories/pub_releases</url>
        </repository>
        <repository>
            <id>ess-repo</id>
            <url>http://repo.ess3.net/content/groups/essentials</url>
        </repository>

        <!-- For Github Repos -->
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
        
</repositories>

    <dependencies>
        <!--Spigot API-->
        <dependency>
            <groupId>org.spigotmc</groupId>
            <artifactId>spigot-api</artifactId>
            <version>1.12.2-R0.1-SNAPSHOT</version>
            <scope>provided</scope>
        </dependency>
        <!--Bukkit API-->
        <dependency>
            <groupId>org.bukkit</groupId>
            <artifactId>bukkit</artifactId>
            <version>1.12.2-R0.1-SNAPSHOT</version>
            <scope>provided</scope>
        </dependency>
        <!--Vault API-->
        <dependency>
            <groupId>net.milkbowl.vault</groupId>
            <artifactId>VaultAPI</artifactId>
            <version>1.7</version>
            <scope>provided</scope>
        </dependency>

        <!--essentials API-->
        <dependency>
            <groupId>net.ess3</groupId>
            <artifactId>Essentials</artifactId>
            <version>2.13-SNAPSHOT</version>
        </dependency>

        <!--I need a release of Coding API ^^-->

    </dependencies>
</project>

[erikzimmermann]

I never worked with maven, so I need a look into it.

[erikzimmermann]

Don't know if you can do something with that: https://github.com/CodingAir/CodingAPI

[Peda1996]

Oh, you should really have a look into dependency managenment things, they are very useful when working with other developers.

[erikzimmermann]

Hey, I'm nearly done with that issue. Would you like to preview it? Add me on discord: #281 ;)