Fix deprecated implicit copy operations (#711) #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolyBlackCat
commented
Jan 20, 2022
| @@ -27,7 +27,7 @@ | |||
| DOCTEST_TEST_CASE("joint reactions") | |||
| { | |||
| b2Vec2 gravity(0, -10.0f); | |||
| b2World world = b2World(gravity); | |||
| b2World world{gravity}; | |||
There was a problem hiding this comment.
This used to call a copy ctor. Was harmless, but no longer compiled after this change (unless you enabled C++17 or newer).
|
Now that I'm thinking about it, this is a breaking change for those who copy a newly constructed |
|
not accepting PRs, but I'll keep the issue open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711
I went over all classes with custom destructors, and
=deleted or=defaulted their copy operations. In cases where that would remove the default constructor, I added it back.