Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess Packages for Config Options #175

Closed
eriq-augustine opened this issue Sep 20, 2018 · 3 comments
Closed

Guess Packages for Config Options #175

eriq-augustine opened this issue Sep 20, 2018 · 3 comments

Comments

@eriq-augustine
Copy link
Owner

For certain config options where we are trying to load a class.
Say choosing the term story for inference.
Or perhaps the CLI choosing what inference or weight learning to use (even though this is not a config issue).

It would be great if someone could specify just the class name instead.
So LazyMPEInference instead of org.linqs.psl.application.inference.LazyMPEInference.

The classloader may not have loaded all the classes yet, so we probably can't rely on that.
Maybe we can have maven put all the classnames in a properties file.
Or have some expected prefixes that we assume if we cannot find the specified class name.

@eriq-augustine
Copy link
Owner Author

Of the proposed options:

  1. The first one will require a new maven plugin (I found none that had this functionality by default).
  2. The second one would require all relevant config calls to declare an expected package.

Of these, 1 is more maintainable.
We will go with that.

@eriq-augustine
Copy link
Owner Author

Plugin implemented and in Maven Central:
https://search.maven.org/search?q=a:list-classes-maven-plugin

@eriq-augustine
Copy link
Owner Author

Complete in 00b6032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant